NetworkManager-0.9.9.0-16covscan.git20131030.el7

List of Defects

Error: CHECKED_RETURN (CWE-252): [#def1]
NetworkManager-0.9.9.0/src/vpn-manager/nm-vpn-connection.c:153: check_return: Calling function "dbus_g_proxy_call(DBusGProxy *, char const *, GError **, GType, ...)" without checking return value (as is done elsewhere 24 out of 30 times).
NetworkManager-0.9.9.0/callouts/nm-dispatcher-action.c:522: example_checked: Example1: "dbus_g_proxy_call(proxy, "RequestName", &error, 64UL, "org.freedesktop.nm_dispatcher", 28UL, 4, 0UL, 28UL, &result, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "RequestName", &error, 64UL, "org.freedesktop.nm_dispatcher", 28UL, 4, 0UL, 28UL, &result, 0UL)".
NetworkManager-0.9.9.0/examples/C/glib/add-connection-dbus-glib.c:81: example_checked: Example2: "dbus_g_proxy_call(proxy, "AddConnection", &error, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), hash, 0UL, dbus_g_object_path_get_g_type(), &new_con_path, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "AddConnection", &error, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), hash, 0UL, dbus_g_object_path_get_g_type(), &new_con_path, 0UL)".
NetworkManager-0.9.9.0/examples/C/glib/get-active-connections-dbus-glib.c:65: example_checked: Example3: "dbus_g_proxy_call(proxy, "GetSettings", &error, 0UL, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), &hash, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "GetSettings", &error, 0UL, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), &hash, 0UL)".
NetworkManager-0.9.9.0/libnm-glib/nm-active-connection.c:127: example_checked: Example4: "dbus_g_proxy_call(proxy, "Get", &error, 64UL, "org.freedesktop.NetworkManager.Connection.Active", 64UL, "Vpn", 0UL, g_value_get_type(), &value, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "Get", &error, 64UL, "org.freedesktop.NetworkManager.Connection.Active", 64UL, "Vpn", 0UL, g_value_get_type(), &value, 0UL)".
NetworkManager-0.9.9.0/libnm-glib/nm-client.c:776: example_checked: Example5: "dbus_g_proxy_call(priv->client_proxy, "DeactivateConnection", &error, dbus_g_object_path_get_g_type(), path, 0UL, 0UL)" has its value checked in "dbus_g_proxy_call(priv->client_proxy, "DeactivateConnection", &error, dbus_g_object_path_get_g_type(), path, 0UL, 0UL)".
NetworkManager-0.9.9.0/src/vpn-manager/nm-vpn-connection.c:153: unchecked_value: No check of the return value of "dbus_g_proxy_call(priv->proxy, "Disconnect", &error, 0UL, 0UL)".

Error: CHECKED_RETURN (CWE-252): [#def2]
NetworkManager-0.9.9.0/src/nm-policy.c:872: check_return: Calling function "nm_platform_ip6_route_add(int, struct in6_addr, int, struct in6_addr, int, int)" without checking return value (as is done elsewhere 13 out of 16 times).
NetworkManager-0.9.9.0/src/nm-policy.c:871: example_checked: Example1: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:873: example_checked: Example2: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:882: example_checked: Example3: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:884: example_checked: Example4: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/platform/nm-platform.c:1553: example_checked: Example5: "nm_platform_ip6_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)" has its value checked in "nm_platform_ip6_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:872: unchecked_value: No check of the return value of "nm_platform_ip6_route_add(parent_ifindex, *gw_addr, 128, in6addr_any, 0, parent_mss)".

Error: CHECKED_RETURN (CWE-252): [#def3]
NetworkManager-0.9.9.0/src/nm-policy.c:883: check_return: Calling function "nm_platform_ip6_route_add(int, struct in6_addr, int, struct in6_addr, int, int)" without checking return value (as is done elsewhere 13 out of 16 times).
NetworkManager-0.9.9.0/src/nm-policy.c:871: example_checked: Example1: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:873: example_checked: Example2: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:882: example_checked: Example3: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:884: example_checked: Example4: "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)" has its value checked in "nm_platform_ip6_route_add(ip_ifindex, in6addr_any, 0, *gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/platform/nm-platform.c:1553: example_checked: Example5: "nm_platform_ip6_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)" has its value checked in "nm_platform_ip6_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:883: unchecked_value: No check of the return value of "nm_platform_ip6_route_add(ip_ifindex, *gw_addr, 128, in6addr_any, 0, mss)".

Error: CHECKED_RETURN (CWE-252): [#def4]
NetworkManager-0.9.9.0/src/nm-policy.c:680: check_return: Calling function "nm_platform_ip4_route_add(int, in_addr_t, int, in_addr_t, int, int)" without checking return value (as is done elsewhere 13 out of 16 times).
NetworkManager-0.9.9.0/src/nm-policy.c:679: example_checked: Example1: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:681: example_checked: Example2: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:690: example_checked: Example3: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:692: example_checked: Example4: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/platform/nm-platform.c:1507: example_checked: Example5: "nm_platform_ip4_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)" has its value checked in "nm_platform_ip4_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:680: unchecked_value: No check of the return value of "nm_platform_ip4_route_add(parent_ifindex, gw_addr, 32, 0U, 0, parent_mss)".

Error: CHECKED_RETURN (CWE-252): [#def5]
NetworkManager-0.9.9.0/src/nm-policy.c:691: check_return: Calling function "nm_platform_ip4_route_add(int, in_addr_t, int, in_addr_t, int, int)" without checking return value (as is done elsewhere 13 out of 16 times).
NetworkManager-0.9.9.0/src/nm-policy.c:679: example_checked: Example1: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:681: example_checked: Example2: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, int_gw, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:690: example_checked: Example3: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:692: example_checked: Example4: "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)" has its value checked in "nm_platform_ip4_route_add(ip_ifindex, 0U, 0, gw_addr, 0, mss)".
NetworkManager-0.9.9.0/src/platform/nm-platform.c:1507: example_checked: Example5: "nm_platform_ip4_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)" has its value checked in "nm_platform_ip4_route_add(ifindex, known_route->network, known_route->plen, known_route->gateway, known_route->metric, known_route->mss)".
NetworkManager-0.9.9.0/src/nm-policy.c:691: unchecked_value: No check of the return value of "nm_platform_ip4_route_add(ip_ifindex, gw_addr, 32, 0U, 0, mss)".

Error: CHECKED_RETURN (CWE-252): [#def6]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-client.c:524: check_return: Calling function "remove(pid_file)" without checking return value. This library function may fail and return an error code.
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-client.c:524: unchecked_value: No check of the return value of "remove(pid_file)".

Error: CHECKED_RETURN (CWE-252): [#def7]
NetworkManager-0.9.9.0/src/platform/tests/dump.c:46: check_return: Calling function "nm_platform_vlan_get_info(int, int *, int *)" without checking return value (as is done elsewhere 5 out of 6 times).
NetworkManager-0.9.9.0/src/devices/nm-device-vlan.c:516: example_checked: Example1: "nm_platform_vlan_get_info(ifindex, &parent_ifindex, &vlan_id)" has its value checked in "nm_platform_vlan_get_info(ifindex, &parent_ifindex, &vlan_id)".
NetworkManager-0.9.9.0/src/nm-manager.c:2475: example_checked: Example2: "nm_platform_vlan_get_info(ifindex, &parent_ifindex, NULL)" has its value checked in "nm_platform_vlan_get_info(ifindex, &parent_ifindex, NULL)".
NetworkManager-0.9.9.0/src/platform/tests/platform.c:319: example_checked: Example3: "nm_platform_vlan_get_info(ifindex, &parent, &vlanid)" has its value checked in "nm_platform_vlan_get_info(ifindex, &parent, &vlanid)".
NetworkManager-0.9.9.0/src/platform/tests/test-link.c:64: example_checked: Example4: "nm_platform_vlan_get_info(2147483647, NULL, NULL)" has its value checked in "nm_platform_vlan_get_info(2147483647, NULL, NULL)".
NetworkManager-0.9.9.0/src/platform/tests/test-link.c:258: example_checked: Example5: "nm_platform_vlan_get_info(ifindex, &vlan_parent, &vlan_id)" has its value checked in "nm_platform_vlan_get_info(ifindex, &vlan_parent, &vlan_id)".
NetworkManager-0.9.9.0/src/platform/tests/dump.c:46: unchecked_value: No check of the return value of "nm_platform_vlan_get_info(link->ifindex, &vlan_parent, &vlan_id)".

Error: CHECKED_RETURN (CWE-252): [#def8]
NetworkManager-0.9.9.0/cli/src/connections.c:6232: check_return: Calling function "nm_connection_verify(NMConnection *, GError **)" without checking return value (as is done elsewhere 180 out of 189 times).
NetworkManager-0.9.9.0/cli/src/connections.c:6241: example_checked: Example1: "nm_connection_verify(connection, &err1)" has its value checked in "nm_connection_verify(connection, &err1)".
NetworkManager-0.9.9.0/libnm-util/tests/test-general.c:1531: example_assign: Example2: Assigning: "success" = return value from "nm_connection_verify(connection, &error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-general.c:1533: example_checked: Example2 (cont.): "success" has its value checked in "success == 0".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:4409: example_checked: Example3: "nm_connection_verify(connection, error)" has its value checked in "nm_connection_verify(connection, error)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:3538: example_checked: Example4: "nm_connection_verify(connection, error)" has its value checked in "nm_connection_verify(connection, error)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:3303: example_checked: Example5: "nm_connection_verify(connection, error)" has its value checked in "nm_connection_verify(connection, error)".
NetworkManager-0.9.9.0/cli/src/connections.c:6232: unchecked_value: No check of the return value of "nm_connection_verify(connection, &tmp_err)".

Error: CHECKED_RETURN (CWE-252): [#def9]
NetworkManager-0.9.9.0/examples/C/glib/list-connections-dbus-glib.c:45: check_return: Calling function "dbus_g_proxy_call(DBusGProxy *, char const *, GError **, GType, ...)" without checking return value (as is done elsewhere 24 out of 30 times).
NetworkManager-0.9.9.0/callouts/nm-dispatcher-action.c:522: example_checked: Example1: "dbus_g_proxy_call(proxy, "RequestName", &error, 64UL, "org.freedesktop.nm_dispatcher", 28UL, 4, 0UL, 28UL, &result, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "RequestName", &error, 64UL, "org.freedesktop.nm_dispatcher", 28UL, 4, 0UL, 28UL, &result, 0UL)".
NetworkManager-0.9.9.0/examples/C/glib/add-connection-dbus-glib.c:81: example_checked: Example2: "dbus_g_proxy_call(proxy, "AddConnection", &error, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), hash, 0UL, dbus_g_object_path_get_g_type(), &new_con_path, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "AddConnection", &error, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), hash, 0UL, dbus_g_object_path_get_g_type(), &new_con_path, 0UL)".
NetworkManager-0.9.9.0/examples/C/glib/get-active-connections-dbus-glib.c:65: example_checked: Example3: "dbus_g_proxy_call(proxy, "GetSettings", &error, 0UL, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), &hash, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "GetSettings", &error, 0UL, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), &hash, 0UL)".
NetworkManager-0.9.9.0/libnm-glib/nm-active-connection.c:127: example_checked: Example4: "dbus_g_proxy_call(proxy, "Get", &error, 64UL, "org.freedesktop.NetworkManager.Connection.Active", 64UL, "Vpn", 0UL, g_value_get_type(), &value, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "Get", &error, 64UL, "org.freedesktop.NetworkManager.Connection.Active", 64UL, "Vpn", 0UL, g_value_get_type(), &value, 0UL)".
NetworkManager-0.9.9.0/libnm-glib/nm-client.c:776: example_checked: Example5: "dbus_g_proxy_call(priv->client_proxy, "DeactivateConnection", &error, dbus_g_object_path_get_g_type(), path, 0UL, 0UL)" has its value checked in "dbus_g_proxy_call(priv->client_proxy, "DeactivateConnection", &error, dbus_g_object_path_get_g_type(), path, 0UL, 0UL)".
NetworkManager-0.9.9.0/examples/C/glib/list-connections-dbus-glib.c:45: unchecked_value: No check of the return value of "dbus_g_proxy_call(proxy, "ListConnections", &error, 0UL, dbus_g_type_get_collection("GPtrArray", dbus_g_object_path_get_g_type()), &con_array, 0UL)".

Error: CHECKED_RETURN (CWE-252): [#def10]
NetworkManager-0.9.9.0/src/settings/nm-agent-manager.c:889: check_return: Calling function "nm_connection_update_secrets(NMConnection *, char const *, GHashTable *, GError **)" without checking return value (as is done elsewhere 12 out of 14 times).
NetworkManager-0.9.9.0/libnm-util/tests/test-general.c:184: example_assign: Example1: Assigning: "success" = return value from "nm_connection_update_secrets(connection, "vpn", settings, &error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-general.c:185: example_checked: Example1 (cont.): "success" has its value checked in "success == 1".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:713: example_assign: Example2: Assigning: "success" = return value from "nm_connection_update_secrets(connection, NULL, secrets, &error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:715: example_checked: Example2 (cont.): "success" has its value checked in "success".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:603: example_assign: Example3: Assigning: "success" = return value from "nm_connection_update_secrets(connection, NULL, secrets, &error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:605: example_checked: Example3 (cont.): "success" has its value checked in "success == 1".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:661: example_assign: Example4: Assigning: "success" = return value from "nm_connection_update_secrets(connection, NULL, secrets, &error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:663: example_checked: Example4 (cont.): "success" has its value checked in "success == 0".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:685: example_assign: Example5: Assigning: "success" = return value from "nm_connection_update_secrets(connection, "802-11-wireless-security", secrets, &error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:690: example_checked: Example5 (cont.): "success" has its value checked in "success".
NetworkManager-0.9.9.0/src/settings/nm-agent-manager.c:889: unchecked_value: No check of the return value of "nm_connection_update_secrets(tmp, req->setting_name, req->existing_secrets, NULL)".

Error: CHECKED_RETURN (CWE-252): [#def11]
NetworkManager-0.9.9.0/cli/src/settings.c:1059: check_return: Calling function "nm_setting_connection_get_permission(NMSettingConnection *, guint32, char const **, char const **, char const **)" without checking return value (as is done elsewhere 7 out of 8 times).
NetworkManager-0.9.9.0/libnm-util/tests/test-general.c:855: example_assign: Example1: Assigning: "success" = return value from "nm_setting_connection_get_permission(s_con, 0U, &ptype, &pitem, &detail)".
NetworkManager-0.9.9.0/libnm-util/tests/test-general.c:856: example_checked: Example1 (cont.): "success" has its value checked in "success == 1".
NetworkManager-0.9.9.0/src/settings/nm-settings-connection.c:251: example_checked: Example2: "nm_setting_connection_get_permission(s_con, i, NULL, &puser, NULL)" has its value checked in "nm_setting_connection_get_permission(s_con, i, NULL, &puser, NULL)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c:6051: example_assign: Example3: Assigning: "success" = return value from "nm_setting_connection_get_permission(s_con, 0U, NULL, &tmp, NULL)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c:6052: example_checked: Example3 (cont.): "success" has its value checked in "success == 1".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c:6065: example_assign: Example4: Assigning: "success" = return value from "nm_setting_connection_get_permission(s_con, 2U, NULL, &tmp, NULL)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c:6066: example_checked: Example4 (cont.): "success" has its value checked in "success == 1".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/writer.c:1503: example_checked: Example5: "nm_setting_connection_get_permission(s_con, i, NULL, &puser, NULL)" has its value checked in "nm_setting_connection_get_permission(s_con, i, NULL, &puser, NULL)".
NetworkManager-0.9.9.0/cli/src/settings.c:1059: unchecked_value: No check of the return value of "nm_setting_connection_get_permission(s_con, i, &perm_type, &perm_item, NULL)".

Error: CHECKED_RETURN (CWE-252): [#def12]
NetworkManager-0.9.9.0/libnm-glib/nm-client.c:1824: check_return: Calling function "nm_utils_init(GError **)" without checking return value (as is done elsewhere 11 out of 12 times).
NetworkManager-0.9.9.0/libnm-util/nm-setting-8021x.c:3716: example_checked: Example1: "nm_utils_init(&error)" has its value checked in "nm_utils_init(&error)".
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:1494: example_checked: Example2: "nm_utils_init(&error)" has its value checked in "nm_utils_init(&error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-general.c:2108: example_checked: Example3: "nm_utils_init(&error)" has its value checked in "nm_utils_init(&error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-secrets.c:728: example_checked: Example4: "nm_utils_init(&error)" has its value checked in "nm_utils_init(&error)".
NetworkManager-0.9.9.0/libnm-util/tests/test-setting-8021x.c:416: example_checked: Example5: "nm_utils_init(&error)" has its value checked in "nm_utils_init(&error)".
NetworkManager-0.9.9.0/libnm-glib/nm-client.c:1824: unchecked_value: No check of the return value of "nm_utils_init(NULL)".

Error: CHECKED_RETURN (CWE-252): [#def13]
NetworkManager-0.9.9.0/src/ppp-manager/nm-pppd-plugin.c:271: check_return: Calling function "dbus_g_proxy_call(DBusGProxy *, char const *, GError **, GType, ...)" without checking return value (as is done elsewhere 24 out of 30 times).
NetworkManager-0.9.9.0/callouts/nm-dispatcher-action.c:522: example_checked: Example1: "dbus_g_proxy_call(proxy, "RequestName", &error, 64UL, "org.freedesktop.nm_dispatcher", 28UL, 4, 0UL, 28UL, &result, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "RequestName", &error, 64UL, "org.freedesktop.nm_dispatcher", 28UL, 4, 0UL, 28UL, &result, 0UL)".
NetworkManager-0.9.9.0/examples/C/glib/add-connection-dbus-glib.c:81: example_checked: Example2: "dbus_g_proxy_call(proxy, "AddConnection", &error, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), hash, 0UL, dbus_g_object_path_get_g_type(), &new_con_path, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "AddConnection", &error, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), hash, 0UL, dbus_g_object_path_get_g_type(), &new_con_path, 0UL)".
NetworkManager-0.9.9.0/examples/C/glib/get-active-connections-dbus-glib.c:65: example_checked: Example3: "dbus_g_proxy_call(proxy, "GetSettings", &error, 0UL, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), &hash, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "GetSettings", &error, 0UL, dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), &hash, 0UL)".
NetworkManager-0.9.9.0/libnm-glib/nm-active-connection.c:127: example_checked: Example4: "dbus_g_proxy_call(proxy, "Get", &error, 64UL, "org.freedesktop.NetworkManager.Connection.Active", 64UL, "Vpn", 0UL, g_value_get_type(), &value, 0UL)" has its value checked in "dbus_g_proxy_call(proxy, "Get", &error, 64UL, "org.freedesktop.NetworkManager.Connection.Active", 64UL, "Vpn", 0UL, g_value_get_type(), &value, 0UL)".
NetworkManager-0.9.9.0/libnm-glib/nm-client.c:776: example_checked: Example5: "dbus_g_proxy_call(priv->client_proxy, "DeactivateConnection", &error, dbus_g_object_path_get_g_type(), path, 0UL, 0UL)" has its value checked in "dbus_g_proxy_call(priv->client_proxy, "DeactivateConnection", &error, dbus_g_object_path_get_g_type(), path, 0UL, 0UL)".
NetworkManager-0.9.9.0/src/ppp-manager/nm-pppd-plugin.c:271: unchecked_value: No check of the return value of "dbus_g_proxy_call(proxy, "NeedSecrets", &err, 0UL, 64UL, &my_username, 64UL, &my_password, 0UL)".

Error: CHECKED_RETURN (CWE-252): [#def14]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-dhcpcd.c:184: check_return: Calling function "remove(priv->pid_file)" without checking return value. This library function may fail and return an error code.
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-dhcpcd.c:184: unchecked_value: No check of the return value of "remove(priv->pid_file)".

Error: CHECKED_RETURN (CWE-252): [#def15]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-dhclient.c:712: check_return: Calling function "remove(priv->conf_file)" without checking return value. This library function may fail and return an error code.
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-dhclient.c:712: unchecked_value: No check of the return value of "remove(priv->conf_file)".

Error: CHECKED_RETURN (CWE-252): [#def16]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-dhclient.c:714: check_return: Calling function "remove(priv->pid_file)" without checking return value. This library function may fail and return an error code.
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-dhclient.c:714: unchecked_value: No check of the return value of "remove(priv->pid_file)".

Error: CHECKED_RETURN (CWE-252): [#def17]
NetworkManager-0.9.9.0/src/nm-dbus-manager.c:443: check_return: Calling function "mkdir("/var/run/NetworkManager", 448U)" without checking return value. This library function may fail and return an error code.
NetworkManager-0.9.9.0/src/nm-dbus-manager.c:443: unchecked_value: No check of the return value of "mkdir("/var/run/NetworkManager", 448U)".

Error: CONSTANT_EXPRESSION_RESULT (CWE-398): [#def18]
NetworkManager-0.9.9.0/src/config/nm-config.c:150: result_independent_of_operands: "((NMConfigPrivate *)g_type_instance_get_private((GTypeInstance *)config, nm_config_get_type()))->connectivity_interval > 2147483647 /* (gint32)2147483647 */" is always false regardless of the values of its operands. This occurs as the logical first operand of '?:'.

Error: COPY_PASTE_ERROR (CWE-398): [#def19]
NetworkManager-0.9.9.0/cli/src/connections.c:6089: original: "ss == menu_ctx.curr_setting" looks like the original copy.
NetworkManager-0.9.9.0/cli/src/connections.c:6111: copy_paste_error: "ss" in "ss == menu_ctx.curr_setting" looks like a copy-paste error.  Should it say "s_tmp" instead?

Error: DEADCODE (CWE-561): [#def20]
NetworkManager-0.9.9.0/cli/src/connections.c:3498: assignment: Assigning: "egress_arr" = "NULL".
NetworkManager-0.9.9.0/cli/src/connections.c:3593: assignment: Assigning: "p" = "egress_arr".
NetworkManager-0.9.9.0/cli/src/connections.c:3593: null: At condition "p", the value of "p" must be NULL.
NetworkManager-0.9.9.0/cli/src/connections.c:3593: dead_error_condition: The condition "p" cannot be true.
NetworkManager-0.9.9.0/cli/src/connections.c:3593: dead_error_line: Execution cannot reach this expression "*p" inside statement "for (p = egress_arr; p && *...".

Error: DEADCODE (CWE-561): [#def21]
NetworkManager-0.9.9.0/cli/src/connections.c:4194: assignment: Assigning: "ip4" = "gw4 = ip6 = gw6 = NULL".
NetworkManager-0.9.9.0/cli/src/connections.c:4199: null: At condition "ip4", the value of "ip4" must be NULL.
NetworkManager-0.9.9.0/cli/src/connections.c:4199: dead_error_condition: The condition "ip4" cannot be true.
NetworkManager-0.9.9.0/cli/src/connections.c:4200: dead_error_begin: Execution cannot reach this statement "ip4addr = nmc_parse_and_bui...".

Error: DEADCODE (CWE-561): [#def22]
NetworkManager-0.9.9.0/cli/src/connections.c:4194: assignment: Assigning: "ip6" = "gw6 = NULL".
NetworkManager-0.9.9.0/cli/src/connections.c:4208: null: At condition "ip6", the value of "ip6" must be NULL.
NetworkManager-0.9.9.0/cli/src/connections.c:4208: dead_error_condition: The condition "ip6" cannot be true.
NetworkManager-0.9.9.0/cli/src/connections.c:4209: dead_error_begin: Execution cannot reach this statement "ip6addr = nmc_parse_and_bui...".

Error: DEADCODE (CWE-561): [#def23]
NetworkManager-0.9.9.0/cli/src/connections.c:6538: assignment: Assigning: "connection" = "NULL".
NetworkManager-0.9.9.0/cli/src/connections.c:6713: null: At condition "connection", the value of "connection" must be NULL.
NetworkManager-0.9.9.0/cli/src/connections.c:6713: dead_error_condition: The condition "connection" cannot be true.
NetworkManager-0.9.9.0/cli/src/connections.c:6714: dead_error_line: Execution cannot reach this statement "g_object_unref(connection);".

Error: DEADCODE (CWE-561): [#def24]
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:719: cond_const: Condition "adhoc", taking false branch. Now the value of "adhoc" is equal to 0.
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:726: const: At condition "adhoc", the value of "adhoc" must be equal to 0.
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:726: dead_error_condition: The condition "adhoc" cannot be true.
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:727: dead_error_line: Execution cannot reach this statement "if (ap_wpa & 0x40U && wifi_...".

Error: DEADCODE (CWE-561): [#def25]
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:747: cond_const: Condition "adhoc", taking false branch. Now the value of "adhoc" is equal to 0.
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:754: const: At condition "adhoc", the value of "adhoc" must be equal to 0.
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:754: dead_error_condition: The condition "adhoc" cannot be true.
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:755: dead_error_line: Execution cannot reach this statement "if (wifi_caps & 4U)return 1;".

Error: FORWARD_NULL (CWE-476): [#def26]
NetworkManager-0.9.9.0/src/nm-wifi-ap-utils.c:304: assign_zero: Assigning: "tmp" = "NULL".
NetworkManager-0.9.9.0/src/nm-wifi-ap-utils.c:305: var_deref_model: Passing null pointer "tmp" to function "__coverity_strcmp(char const *, char const *)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def27]
NetworkManager-0.9.9.0/src/nm-wifi-ap-utils.c:314: assign_zero: Assigning: "tmp" = "NULL".
NetworkManager-0.9.9.0/src/nm-wifi-ap-utils.c:315: var_deref_model: Passing null pointer "tmp" to function "__coverity_strcmp(char const *, char const *)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def28]
NetworkManager-0.9.9.0/src/nm-wifi-ap-utils.c:324: assign_zero: Assigning: "tmp" = "NULL".
NetworkManager-0.9.9.0/src/nm-wifi-ap-utils.c:325: var_deref_model: Passing null pointer "tmp" to function "__coverity_strcmp(char const *, char const *)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def29]
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:419: var_compare_op: Comparing "ssid1" to null implies that "ssid1" might be null.
NetworkManager-0.9.9.0/libnm-util/nm-utils.c:422: var_deref_op: Dereferencing null pointer "ssid1".

Error: FORWARD_NULL (CWE-476): [#def30]
NetworkManager-0.9.9.0/cli/src/connections.c:446: var_compare_op: Comparing "path" to null implies that "path" might be null.
NetworkManager-0.9.9.0/cli/src/connections.c:453: var_deref_model: Passing null pointer "path" to function "__coverity_strcmp(char const *, char const *)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def31]
NetworkManager-0.9.9.0/cli/src/connections.c:716: var_compare_op: Comparing "a_path" to null implies that "a_path" might be null.
NetworkManager-0.9.9.0/cli/src/connections.c:726: var_deref_model: Passing null pointer "a_path" to function "__coverity_strcmp(char const *, char const *)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def32]
NetworkManager-0.9.9.0/cli/src/connections.c:715: var_compare_op: Comparing "path" to null implies that "path" might be null.
NetworkManager-0.9.9.0/cli/src/connections.c:726: var_deref_model: Passing null pointer "path" to function "__coverity_strcmp(char const *, char const *)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def33]
NetworkManager-0.9.9.0/src/dns-manager/nm-dns-utils.c:31: assign_zero: Assigning: "str" = "NULL".
NetworkManager-0.9.9.0/src/dns-manager/nm-dns-utils.c:53: var_deref_model: Passing null pointer "str" to function "__coverity_strcmp(char const *, char const *)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def34]
NetworkManager-0.9.9.0/cli/src/connections.c:6071: var_compare_op: Comparing "menu_ctx.curr_setting" to null implies that "menu_ctx.curr_setting" might be null.
NetworkManager-0.9.9.0/cli/src/connections.c:6084: alias_transfer: Assigning: "ss" = "menu_ctx.curr_setting".
NetworkManager-0.9.9.0/cli/src/connections.c:6088: var_deref_model: Passing null pointer "ss" to function "connection_remove_setting(NMConnection *, NMSetting *)", which dereferences it.
NetworkManager-0.9.9.0/cli/src/connections.c:5448:3: deref_parm: Directly dereferencing parameter "setting".

Error: FORWARD_NULL (CWE-476): [#def35]
NetworkManager-0.9.9.0/src/ppp-manager/nm-pppd-plugin.c:262: var_compare_op: Comparing "username" to null implies that "username" might be null.
NetworkManager-0.9.9.0/src/ppp-manager/nm-pppd-plugin.c:292: var_deref_model: Passing null pointer "username" to function "strncpy(char * restrict, char const * restrict, size_t)", which dereferences it.

Error: FORWARD_NULL (CWE-476): [#def36]
NetworkManager-0.9.9.0/src/settings/plugins/keyfile/writer.c:893: var_compare_op: Comparing "pspec" to null implies that "pspec" might be null.
NetworkManager-0.9.9.0/src/settings/plugins/keyfile/writer.c:905: var_deref_op: Dereferencing null pointer "pspec".

Error: FORWARD_NULL (CWE-476): [#def37]
NetworkManager-0.9.9.0/src/vpn-manager/nm-vpn-connection.c:999: var_compare_op: Comparing "priv->ip6_external_gw" to null implies that "priv->ip6_external_gw" might be null.
NetworkManager-0.9.9.0/src/vpn-manager/nm-vpn-connection.c:1088: alias_transfer: Assigning: "__b" = "priv->ip6_external_gw".
NetworkManager-0.9.9.0/src/vpn-manager/nm-vpn-connection.c:1088: var_deref_op: Dereferencing null pointer "__b".

Error: FORWARD_NULL (CWE-476): [#def38]
NetworkManager-0.9.9.0/src/settings/plugins/keyfile/writer.c:706: assign_zero: Assigning: "objtype" = "NULL".
NetworkManager-0.9.9.0/src/settings/plugins/keyfile/writer.c:717: var_deref_op: Dereferencing null pointer "objtype".

Error: NEGATIVE_RETURNS (CWE-394): [#def39]
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/shvar.c:368: negative_return_fn: Function "dup(s->fd)" returns a negative number.
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/shvar.c:368: var_assign: Assigning: signed variable "tmpfd" = "dup(int)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/shvar.c:369: negative_returns: "tmpfd" is passed to a parameter that cannot be negative.

Error: NO_EFFECT (CWE-398): [#def40]
NetworkManager-0.9.9.0/src/platform/nm-platform.c:1077: unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "preferred >= 0U".

Error: NO_EFFECT (CWE-398): [#def41]
NetworkManager-0.9.9.0/src/platform/nm-platform.c:1092: unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "preferred >= 0U".

Error: NO_EFFECT (CWE-398): [#def42]
NetworkManager-0.9.9.0/libnm-util/nm-setting-bond.c:254: array_null: Comparing an array to null is not useful: "def->list == NULL".

Error: NO_EFFECT (CWE-398): [#def43]
NetworkManager-0.9.9.0/libnm-util/nm-setting-bond.c:248: array_null: Comparing an array to null is not useful: "def->list".

Error: NO_EFFECT (CWE-398): [#def44]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-manager.c:304: array_null: Comparing an array to null is not useful: """".

Error: NO_EFFECT (CWE-398): [#def45]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-manager.c:302: array_null: Comparing an array to null is not useful: ""/sbin/dhclient"".

Error: NO_EFFECT (CWE-398): [#def46]
NetworkManager-0.9.9.0/src/supplicant-manager/nm-supplicant-config.c:249: unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "ap_scan >= 0U".

Error: NO_EFFECT (CWE-398): [#def47]
NetworkManager-0.9.9.0/cli/src/devices.c:426: unsigned_compare: This less-than-zero comparison of an unsigned value is never true. "nm_access_point_get_strength(ap) < 0".

Error: NO_EFFECT (CWE-398): [#def48]
NetworkManager-0.9.9.0/src/devices/nm-device-wifi.c:732: unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "percent >= 0U".

Error: NO_EFFECT (CWE-398): [#def49]
NetworkManager-0.9.9.0/src/wifi/wifi-utils.c:202: unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "channel >= 0U".

Error: NULL_RETURNS (CWE-476): [#def50]
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:2824: returned_null: Function "svGetValue(shvarFile *, char const *, gboolean)" returns null (checked 117 out of 132 times).
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/shvar.c:219:6: return_null: Explicitly returning null.
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/plugin.c:586: example_assign: Example1: Assigning: "hostname" = return value from "svGetValue(network, "HOSTNAME", 0)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/plugin.c:592: example_checked: Example1 (cont.): "hostname" has its value checked in "hostname".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:3757: example_assign: Example2: Assigning: "value" = return value from "svGetValue(ifcfg, "DEVICE", 0)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:3758: example_checked: Example2 (cont.): "value" has its value checked in "value".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:4454: example_assign: Example3: Assigning: "uuid" = return value from "svGetValue(ifcfg, "UUID", 0)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:4455: example_checked: Example3 (cont.): "uuid" has its value checked in "uuid".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/shvar.c:236: example_assign: Example4: Assigning: "tmp" = return value from "svGetValue(s, key, 0)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/shvar.c:237: example_checked: Example4 (cont.): "tmp" has its value checked in "tmp".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c:7617: example_assign: Example5: Assigning: "tmp" = return value from "svGetValue(ifcfg, "ESSID", 1)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c:7618: example_checked: Example5 (cont.): "tmp" has its value checked in "tmp != NULL".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:2824: var_assigned: Assigning: "value" = null return value from "svGetValue(shvarFile *, char const *, gboolean)".
NetworkManager-0.9.9.0/src/settings/plugins/ifcfg-rh/reader.c:2864: dereference: Dereferencing a pointer that might be null "value" when calling "__coverity_strcmp(char const *, char const *)".

Error: RESOURCE_LEAK (CWE-772): [#def51]
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66: open_fn: Returning handle opened by function "open(char const *, int, ...)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66: var_assign: Assigning: "res" = handle returned from "open(path, flags, mode)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66: overwrite_var: Overwriting handle "res" in "res = open(path, flags, mode)" leaks the handle.

Error: RESOURCE_LEAK (CWE-772): [#def52]
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:123: open_fn: Returning handle opened by function "_open_fd_noatime(char const *)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:83:5: open_fn: Returning handle opened by function "open_nointr(char const *, int, mode_t)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66:5: open_fn: Returning handle opened by function "open(char const *, int, ...)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66:5: var_assign: Assigning: "res" = "open(path, flags, mode)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:68:3: return_handle: Returning opened handle "res".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:83:5: var_assign: Assigning: "fd" = "open_nointr(path, 0, 0U)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:85:3: return_handle: Returning opened handle "fd".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:123: var_assign: Assigning: "fd" = handle returned from "_open_fd_noatime(path)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:130: leaked_handle: Handle variable "fd" going out of scope leaks the handle.

Error: RESOURCE_LEAK (CWE-772): [#def53]
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:339: open_fn: Returning handle opened by function "open_nointr(char const *, int, mode_t)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66:5: open_fn: Returning handle opened by function "open(char const *, int, ...)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66:5: var_assign: Assigning: "res" = "open(path, flags, mode)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:68:3: return_handle: Returning opened handle "res".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:339: var_assign: Assigning: "fd" = handle returned from "open_nointr(gs_file_get_path_cached(file), 193, mode)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:348: noescape: Resource "fd" is not freed or pointed-to in function "fchown(int, __uid_t, __gid_t)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:367: leaked_handle: Handle variable "fd" going out of scope leaks the handle.

Error: RESOURCE_LEAK (CWE-772): [#def54]
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:392: open_fn: Returning handle opened by function "open_nointr(char const *, int, mode_t)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66:5: open_fn: Returning handle opened by function "open(char const *, int, ...)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:66:5: var_assign: Assigning: "res" = "open(path, flags, mode)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:68:3: return_handle: Returning opened handle "res".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:392: var_assign: Assigning: "fd" = handle returned from "open_nointr(gs_file_get_path_cached(file), 193, mode)".
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:411: leaked_handle: Handle variable "fd" going out of scope leaks the handle.

Error: REVERSE_INULL (CWE-476): [#def55]
NetworkManager-0.9.9.0/cli/src/connections.c:365: deref_ptr: Directly dereferencing pointer "print_settings_array".
NetworkManager-0.9.9.0/cli/src/connections.c:385: check_after_deref: Null-checking "print_settings_array" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Error: REVERSE_INULL (CWE-476): [#def56]
NetworkManager-0.9.9.0/cli/src/utils.c:97: alias: Assigning: "p" = "arg_arr".
NetworkManager-0.9.9.0/cli/src/utils.c:124: alias: Assigning: "p" = "arg_arr".
NetworkManager-0.9.9.0/cli/src/utils.c:134: check_after_deref: Null-checking "p" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
NetworkManager-0.9.9.0/cli/src/utils.c:97: deref_ptr: Directly dereferencing pointer "p".
NetworkManager-0.9.9.0/cli/src/utils.c:124: deref_ptr: Directly dereferencing pointer "p".

Error: REVERSE_INULL (CWE-476): [#def57]
NetworkManager-0.9.9.0/cli/src/connections.c:866: deref_ptr: Directly dereferencing pointer "print_groups".
NetworkManager-0.9.9.0/cli/src/connections.c:975: check_after_deref: Null-checking "print_groups" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Error: REVERSE_INULL (CWE-476): [#def58]
NetworkManager-0.9.9.0/src/nm-manager.c:3030: deref_ptr: Directly dereferencing pointer "error".
NetworkManager-0.9.9.0/src/nm-manager.c:3198: check_after_deref: Null-checking "error" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Error: REVERSE_INULL (CWE-476): [#def59]
NetworkManager-0.9.9.0/libgsystem/gsystem-subprocess.c:949: deref_ptr_in_call: Dereferencing pointer "context".
NetworkManager-0.9.9.0/libgsystem/gsystem-subprocess-context.c:330:3: deref_parm: Directly dereferencing parameter "self".
NetworkManager-0.9.9.0/libgsystem/gsystem-subprocess.c:960: check_after_deref: Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Error: REVERSE_INULL (CWE-476): [#def60]
NetworkManager-0.9.9.0/src/settings/plugins/keyfile/reader.c:1012: check_after_deref: Null-checking "parser" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
NetworkManager-0.9.9.0/src/settings/plugins/keyfile/reader.c:979: deref_ptr: Directly dereferencing pointer "parser".

Error: UNINIT (CWE-457): [#def61]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-client.c:324: var_decl: Declaring variable "cp" without initializer.
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-client.c:331: uninit_use: Using uninitialized value "cp".

Error: UNREACHABLE (CWE-561): [#def62]
NetworkManager-0.9.9.0/libgsystem/gsystem-file-utils.c:510: unreachable: Since the loop increment "i++;" is unreachable, the loop body will never execute more than once.

Error: UNUSED_VALUE (CWE-563): [#def63]
NetworkManager-0.9.9.0/src/nm-dispatcher.c:342: returned_pointer: Pointer "call" returned by "dbus_g_proxy_begin_call_with_timeout(proxy, "Action", dispatcher_done_cb(DBusGProxy *, DBusGProxyCall *, gpointer), info, (GDestroyNotify)dispatcher_info_free(DispatchInfo *), 15000, 64UL, action_to_string(action), dbus_g_type_get_map("GHashTable", 64UL, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type())), connection_hash, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), connection_props, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), device_props, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), device_ip4_props, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), device_ip6_props, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), device_dhcp4_props, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), device_dhcp6_props, 64UL, (vpn_iface ? vpn_iface : ""), dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), vpn_ip4_props, dbus_g_type_get_map("GHashTable", 64UL, g_value_get_type()), vpn_ip6_props, 0UL)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def64]
NetworkManager-0.9.9.0/libnm-util/nm-setting-vlan.c:261: returned_pointer: Pointer "priv" returned by "g_type_instance_get_private((GTypeInstance *)setting, nm_setting_vlan_get_type())" is never used.

Error: UNUSED_VALUE (CWE-563): [#def65]
NetworkManager-0.9.9.0/libnm-util/nm-setting-wireless.c:165: returned_pointer: Pointer "priv" returned by "g_type_instance_get_private((GTypeInstance *)s_wireless, nm_setting_wireless_get_type())" is never used.

Error: UNUSED_VALUE (CWE-563): [#def66]
NetworkManager-0.9.9.0/src/modem-manager/nm-modem-manager.c:200: returned_pointer: Pointer "call" returned by "dbus_g_proxy_begin_call_with_timeout(proxy, "EnumerateDevices", mm_poke_cb(DBusGProxy *, DBusGProxyCall *, gpointer), NULL, NULL, 5000, 0UL)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def67]
NetworkManager-0.9.9.0/src/tests/test-dhcp-options.c:237: returned_pointer: Pointer "address" returned by "nm_ip4_config_get_address(ip4_config, 0U)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def68]
NetworkManager-0.9.9.0/src/nm-policy.c:1741: returned_pointer: Pointer "ip_iface" returned by "nm_vpn_connection_get_ip_iface(vpn)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def69]
NetworkManager-0.9.9.0/src/nm-policy.c:1742: returned_pointer: Pointer "parent" returned by "nm_vpn_connection_get_parent_device(vpn)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def70]
NetworkManager-0.9.9.0/src/config/tests/test-config.c:89: returned_pointer: Pointer "value" returned by "nm_config_get_value(config, "extra-section", "no-key", &error)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def71]
NetworkManager-0.9.9.0/src/config/tests/test-config.c:93: returned_pointer: Pointer "value" returned by "nm_config_get_value(config, "no-section", "no-key", &error)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def72]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-manager.c:205: returned_pointer: Pointer "priv" returned by "g_type_instance_get_private((GTypeInstance *)manager, nm_dhcp_manager_get_type())" is never used.

Error: UNUSED_VALUE (CWE-563): [#def73]
NetworkManager-0.9.9.0/src/dhcp-manager/nm-dhcp-dhcpcd.c:110: returned_pointer: Pointer "uuid" returned by "nm_dhcp_client_get_uuid(client)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def74]
NetworkManager-0.9.9.0/src/nm-dispatcher.c:195: returned_pointer: Pointer "script" returned by "g_value_get_string(tmp)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def75]
NetworkManager-0.9.9.0/src/devices/nm-device-infiniband.c:81: returned_pointer: Pointer "priv" returned by "g_type_instance_get_private((GTypeInstance *)self, nm_device_infiniband_get_type())" is never used.

Error: UNUSED_VALUE (CWE-563): [#def76]
NetworkManager-0.9.9.0/src/devices/nm-device-ethernet.c:239: returned_pointer: Pointer "priv" returned by "g_type_instance_get_private((GTypeInstance *)self, nm_device_ethernet_get_type())" is never used.

Error: UNUSED_VALUE (CWE-563): [#def77]
NetworkManager-0.9.9.0/src/config/tests/test-config.c:118: returned_pointer: Pointer "config" returned by "nm_config_new(&error)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def78]
NetworkManager-0.9.9.0/src/config/tests/test-config.c:268: returned_pointer: Pointer "config" returned by "nm_config_new(&error)" is never used.

Error: UNUSED_VALUE (CWE-563): [#def79]
NetworkManager-0.9.9.0/src/config/tests/test-config.c:107: returned_pointer: Pointer "config" returned by "nm_config_new(&error)" is never used.

Error: VARARGS (CWE-237): [#def80]
NetworkManager-0.9.9.0/src/platform/tests/test-common.c:103: va_init: Initializing va_list "ap".
NetworkManager-0.9.9.0/src/platform/tests/test-common.c:110: missing_va_end: va_end was not called for "ap".

Scan Properties

analyzercoverity
analyzer-args--wait-for-license -co BAD_FREE:allow_first_field:true
analyzer-versionCoverity Static Analysis for C/C++ version 6.5.3 on Linux 2.6.32-279.el6.x86_64 x86_64\nInternal version numbers: 7d3b4ace9c p-davis-push-13307.195
compilation-unit-count310
compilation-unit-ratio100
hostcov01.lab.eng.brq.redhat.com
lines-processed232079
mock-configrhel-7-x86_64
project-nameNetworkManager-0.9.9.0-16covscan.git20131030.el7
time-created2013-10-30 13:00:16
time-elapsed-analysis00:03:00
time-finished2013-10-30 13:10:16
toolcov-mockbuild
tool-args'rhel-7-x86_64' '/tmp/covscan_GIlX5_/NetworkManager-0.9.9.0-16covscan.git20131030.el7.src.rpm'
tool-versioncov-mockbuild-0.20131015_4954996-1.el6.noarch csdiff-0.20131015_794deb1-1.el6.x86_64