Bug 1110511 - Implement about:tabcrashed spec
This should be pretty straight-forward, I think. Ursula got me started, and I need to just drive it through to the end.
She's got a draft of the front-end done, and I think it's just matter
of figuring out what POST parameters I need to send along… I think.
Ah, here's some useful info from
here
:
canonical_standard_raw_crash = DotDict({
"uuid": '00000000-0000-0000-0000-000002140504',
"InstallTime": "1335439892",
"AdapterVendorID": "0x1002",
"TotalVirtualMemory": "4294836224",
"Comments": "why did my browser crash? #fail",
"Theme": "classic/1.0",
"Version": "12.0",
"Email": "noreply@mozilla.com",
"Vendor": "Mozilla",
"EMCheckCompatibility": "true",
"Throttleable": "1",
"id": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}",
"buildid": "20120420145725",
"AvailablePageFile": "10641510400",
"version": "12.0",
"AdapterDeviceID": "0x7280",
"ReleaseChannel": "release",
"submitted_timestamp": "2012-05-08T23:26:33.454482+00:00",
"URL": "http://www.mozilla.com",
"timestamp": 1336519593.454627,
"Notes": "AdapterVendorID: 0x1002, AdapterDeviceID: 0x7280, "
"AdapterSubsysID: 01821043, "
"AdapterDriverVersion: 8.593.100.0\nD3D10 Layers? D3D10 "
"Layers- D3D9 Layers? D3D9 Layers- ",
"CrashTime": "1336519554",
"Winsock_LSP": "MSAFD Tcpip [TCP/IPv6] : 2 : 1 : \n "
"MSAFD Tcpip [UDP/IPv6] : 2 : 2 : "
"%SystemRoot%\\system32\\mswsock.dll \n "
"MSAFD Tcpip [RAW/IPv6] : 2 : 3 : \n "
"MSAFD Tcpip [TCP/IP] : 2 : 1 : "
"%SystemRoot%\\system32\\mswsock.dll \n "
"MSAFD Tcpip [UDP/IP] : 2 : 2 : \n "
"MSAFD Tcpip [RAW/IP] : 2 : 3 : "
"%SystemRoot%\\system32\\mswsock.dll \n "
"\u041f\u043e\u0441\u0442\u0430\u0432\u0449\u0438\u043a "
"\u0443\u0441\u043b\u0443\u0433 RSVP TCPv6 : 2 : 1 : \n "
"\u041f\u043e\u0441\u0442\u0430\u0432\u0449\u0438\u043a "
"\u0443\u0441\u043b\u0443\u0433 RSVP TCP : 2 : 1 : "
"%SystemRoot%\\system32\\mswsock.dll \n "
"\u041f\u043e\u0441\u0442\u0430\u0432\u0449\u0438\u043a "
"\u0443\u0441\u043b\u0443\u0433 RSVP UDPv6 : 2 : 2 : \n "
"\u041f\u043e\u0441\u0442\u0430\u0432\u0449\u0438\u043a "
"\u0443\u0441\u043b\u0443\u0433 RSVP UDP : 2 : 2 : "
"%SystemRoot%\\system32\\mswsock.dll",
"FramePoisonBase": "00000000f0de0000",
"AvailablePhysicalMemory": "2227773440",
"FramePoisonSize": "65536",
"StartupTime": "1336499438",
"Add-ons": "adblockpopups@jessehakanen.net:0.3,"
"dmpluginff%40westbyte.com:1%2C4.8,"
"firebug@software.joehewitt.com:1.9.1,"
"killjasmin@pierros14.com:2.4,"
"support@surfanonymous-free.com:1.0,"
"uploader@adblockfilters.mozdev.org:2.1,"
"{a0d7ccb3-214d-498b-b4aa-0e8fda9a7bf7}:20111107,"
"{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}:2.0.3,"
"anttoolbar@ant.com:2.4.6.4,"
"{972ce4c6-7e08-4474-a285-3208198ce6fd}:12.0,"
"elemhidehelper@adblockplus.org:1.2.1",
"BuildID": "20120420145725",
"SecondsSinceLastCrash": "86985",
"ProductName": "Firefox",
"legacy_processing": 0,
"AvailableVirtualMemory": "3812708352",
"SystemMemoryUsePercentage": "48",
"ProductID": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}",
"Distributor": "Mozilla",
"Distributor_version": "12.0",
})
And it looks like CrashSubmit will allow us to send the "extra keyvals" here… so that's good.
So the things we've added:
- addComment -> Comments
- includeAddress -> URL
- addEmail -> Email
Bold the "Mozilla Crash Reporter" string
Adding a regression test now...
Find out what the default values should be for the checkboxes, and where to store the user preferences
For the toolkit crash reporter, on Windows, we save the final values to
the registry. On Linux, to a file. On OS X, we use some kind of
NSUserDefaults
thing...
So we can use the standard prefs service with tab crashing, which is good. What defaults do we use for the crash reporter?
Uh… ok, this is interesting:
So if the user hasn't specified whether they'd like to send a crash report, we choose semi-randomly based on a probability...
Y'know what - I'm just going to file a follow-up to determine what the defaults should be.
But we should save the preferences from the user once they come in.
File follow-up to figure out defaults.
Done
.
File a follow-up to add a transition to show the Submission thing.
Done
.
File a follow-up to change extraExtraKeyVals to just extraKeyVals.
Done
.
File a follow-up to ask privacy if it’s okay that we’re storing the email address in prefs like this.
Done
.
File a follow-up to see if we can maybe get the email address from the Form History stuff.
Done
.
|
|