/home/maarten/src/libreoffice/core/odk/source/unoapploader/unx/unoapploader.c

Bug Summary

File:	home/maarten/src/libreoffice/core/odk/source/unoapploader/unx/unoapploader.c
Warning:	line 213, column 15 Potential leak of memory pointed to by 'envstr'

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple x86_64-unknown-linux-gnu -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name unoapploader.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 2 -mframe-pointer=all -fmath-errno -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -fno-split-dwarf-inlining -debugger-tuning=gdb -resource-dir /usr/lib64/clang/11.0.0 -D BOOST_ERROR_CODE_HEADER_ONLY -D BOOST_SYSTEM_NO_DEPRECATED -D CPPU_ENV=gcc3 -D LINUX -D OSL_DEBUG_LEVEL=1 -D SAL_LOG_INFO -D SAL_LOG_WARN -D UNIX -D UNX -D X86_64 -D _PTHREADS -D _REENTRANT -D LIBO_INTERNAL_ONLY -I /home/maarten/src/libreoffice/core/include -I /usr/lib/jvm/java-11-openjdk-11.0.9.10-0.0.ea.fc33.x86_64/include -I /usr/lib/jvm/java-11-openjdk-11.0.9.10-0.0.ea.fc33.x86_64/include/linux -I /home/maarten/src/libreoffice/core/config_host -internal-isystem /usr/local/include -internal-isystem /usr/lib64/clang/11.0.0/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -O0 -std=gnu89 -fdebug-compilation-dir /home/maarten/src/libreoffice/core -ferror-limit 19 -fvisibility hidden -stack-protector 2 -fgnuc-version=4.2.1 -debug-info-kind=constructor -analyzer-output=html -faddrsig -o /home/maarten/tmp/wis/scan-build-libreoffice/output/report/2020-10-07-141433-9725-1 -x c /home/maarten/src/libreoffice/core/odk/source/unoapploader/unx/unoapploader.c

1/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
2/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
*   Licensed to the Apache Software Foundation (ASF) under one or more
*   contributor license agreements. See the NOTICE file distributed
*   with this work for additional information regarding copyright
*   ownership. The ASF licenses this file to you under the Apache
*   License, Version 2.0 (the "License"); you may not use this file
*   except in compliance with the License. You may obtain a copy of
*   the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/

20#include <stdlib.h>
21#include <unistd.h>
22#include <stdio.h>
23#include <string.h>
24#include <sys/stat.h>

26#ifdef LINUX1
27#define __USE_GNU
28#endif
29#include <dlfcn.h>

31#include <cppuhelper/findsofficepath.h>
32#include <rtl/string.h>
33#include <sal/types.h>

35static char* getPath(void);
36static char* createCommandName( char* argv0 );

38static const int SEPARATOR = '/';
39static const char* PATHSEPARATOR = ":";


42/*
* The main function implements a loader for applications which use UNO.
*
* <p>This code runs on the Unix/Linux platforms only.</p>
*
* <p>The main function detects a UNO installation on the system and adds the
* relevant directories of the installation to the LD_LIBRARY_PATH environment
* variable. After that, the application process is loaded and started, whereby
* the new process inherits the environment of the calling process, including
* the modified LD_LIBRARY_PATH environment variable. The application's
* executable name must be the same as the name of this executable, prefixed
* by '_'.</p>
* <p>On MACOSX DYLD_LIBRARY_PATH is used instead of LD_LIBRARY_PATH!<p>
*
* <p>A UNO installation can be specified by the user by setting the UNO_PATH
* environment variable to the program directory of the UNO installation.
* If no installation is specified by the user, the default installation on
* the system will be taken. The default installation is found from the
* PATH environment variable. This requires that the 'soffice' executable or
* a symbolic link is in one of the directories listed in the PATH environment
* variable.</p>
*/
64int main( int argc, char *argv[] )
65{
  char* path;
  char* cmdname;

  (void) argc; /* avoid warning about unused parameter */

  /* get the path of the UNO installation */
  path = getPath();

  if ( path0.1
'path' is not equal to NULL
 != NULL((void*)0) )
1
Taking true branch→
  {
76#if defined(MACOSX)
      static const char* ENVVARNAME = "DYLD_LIBRARY_PATH";
78#elif defined(AIX)
      static const char* ENVVARNAME = "LIBPATH";
80#else
      static const char* ENVVARNAME = "LD_LIBRARY_PATH";
82#endif
      char* libpath;
      char* value;
      char* envstr;
      int size;

      size_t pathlen = strlen(path);
      struct stat stats;
      int ret;

      static char const unoinfoSuffix[] = "/unoinfo";
      char * unoinfo = malloc(
          pathlen + RTL_CONSTASCII_LENGTH(unoinfoSuffix)((sal_Int32)((sizeof (unoinfoSuffix) / sizeof ((unoinfoSuffix
)[0]))-1)) + 1);
          /*TODO: overflow */
      if (unoinfo == NULL((void*)0)) {
2
←
Assuming 'unoinfo' is not equal to NULL→
3
←
Taking false branch→
          free(path);
          fprintf(stderrstderr, "Error: out of memory!\n");
          exit(EXIT_FAILURE1);
      }
      strcpy(unoinfo, path);
      strcpy(
          unoinfo + pathlen,
          unoinfoSuffix + (pathlen == 0 || path[pathlen - 1] != '/' ? 0 : 1));
4
←
Assuming 'pathlen' is equal to 0→
      ret = lstat(unoinfo, &stats);
      free(unoinfo);

      if (ret == 0) {
5
←
Assuming 'ret' is not equal to 0→
6
←
Taking false branch→
          char * cmd = malloc(
              2 * pathlen + RTL_CONSTASCII_LENGTH("/unoinfo c++")((sal_Int32)((sizeof ("/unoinfo c++") / sizeof (("/unoinfo c++"
)[0]))-1)) + 1);
              /*TODO: overflow */
          char const * p;
          char * q;
          FILE * f;
          size_t n = 1000;
          size_t old = 0;
          if (cmd == NULL((void*)0)) {
              fprintf(stderrstderr, "Error: out of memory!\n");
              exit(EXIT_FAILURE1);
          }
          p = path;
          q = cmd;
          while (*p != '\0') {
              *q++ = '\\';
              *q++ = *p++;
          }
          if (p == path || p[-1] != '/') {
              *q++ = '/';
          }
          strcpy(q, "unoinfo c++");
          f = popen(cmd, "r");
          free(cmd);
          if (f == NULL((void*)0))
          {
              fprintf(stderrstderr, "Error: calling unoinfo failed!\n");
              exit(EXIT_FAILURE1);
          }
          libpath = NULL((void*)0);
          for (;;) {
              size_t m;
              libpath = realloc(libpath, n);
              if (libpath == NULL((void*)0)) {
                  fprintf(
                      stderrstderr,
                      "Error: out of memory reading unoinfo output!\n");
                  exit(EXIT_FAILURE1);
              }
              m = fread(libpath + old, 1, n - old - 1, f);
              if (m != n - old - 1) {
                  if (ferror(f)) {
                      fprintf(stderrstderr, "Error: cannot read unoinfo output!\n");
                      exit(EXIT_FAILURE1);
                  }
                  libpath[old + m] = '\0';
                  break;
              }
              if (n >= SAL_MAX_SIZE((sal_uInt64) 0xFFFFFFFFFFFFFFFFul) / 2) {
                  fprintf(
                      stderrstderr,
                      "Error: out of memory reading unoinfo output!\n");
                  exit(EXIT_FAILURE1);
              }
              old = n - 1;
              n *= 2;
          }
          if (pclose(f) != 0) {
              fprintf(stderrstderr, "Error: executing unoinfo failed!\n");
              exit(EXIT_FAILURE1);
          }
          free(path);
      }
      else
      {
          /* Assume an old OOo 2.x installation without unoinfo: */
          libpath = path;
      }

      value = getenv( ENVVARNAME );

      // workaround for finding wrong libsqlite3.dylib in the office installation
      // For MacOS > 10.6 nss uses the system lib -> unresolved symbol _sqlite3_wal_checkpoint
182#ifdef MACOSX
      size = strlen( ENVVARNAME ) + strlen( "=/usr/lib:" ) + strlen( libpath ) + 1;
184#else
      size = strlen( ENVVARNAME ) + strlen( "=" ) + strlen( libpath ) + 1;
186#endif
      if ( value != NULL((void*)0) )
7
←
Assuming 'value' is equal to NULL→
8
←
Taking false branch→
          size += strlen( PATHSEPARATOR ) + strlen( value );
      envstr = (char*) malloc( size );
9
←
Memory is allocated→
      strcpy( envstr, ENVVARNAME );
191#ifdef MACOSX
      strcat( envstr, "=/usr/lib:" );
193#else
      strcat( envstr, "=" );
195#endif
      strcat( envstr, libpath );
      free( libpath );
      if ( value9.1
'value' is equal to NULL
 != NULL((void*)0) )
10
←
Taking false branch→
      {
          strcat( envstr, PATHSEPARATOR );
          strcat( envstr, value );
      }
      /* coverity[tainted_data : FALSE] */
      putenv( envstr );
  }
  else
  {
      fprintf( stderrstderr, "Warning: no office installation found!\n" );
      fflush( stderrstderr );
  }

  /* set the executable name for the application process */
  cmdname = createCommandName( argv[0] );
11
←
Potential leak of memory pointed to by 'envstr'
  argv[0] = cmdname;

  /*
   * create the application process;
   * if successful, execvp doesn't return to the calling process
   */
  /* coverity[tainted_string] - createCommandName creates a safe string */
  execvp( cmdname, argv );
  fprintf( stderrstderr, "Error: execvp failed!\n" );
  fflush( stderrstderr );

  return 0;
226}

228/*
* Gets the path of a UNO installation.
*
* @return the installation path or NULL, if no installation was specified or
*         found, or if an error occurred.
*         Returned pointer must be released with free()
*/
235char* getPath(void)
236{
  char* path = cppuhelper_detail_findSofficePath();

  if ( path == NULL((void*)0) )
  {
      fprintf( stderrstderr, "Warning: getting path from PATH environment "
               "variable failed!\n" );
      fflush( stderrstderr );
  }

  return path;
247}

249/*
* Creates the application's executable file name.
*
* <p>The application's executable file name is the name of this executable
* prefixed by '_'.</p>
*
* @param argv0 specifies the argv[0] parameter of the main function
*
* @return the application's executable file name or NULL, if an error occurred
*/
259char* createCommandName( char* argv0 )
260{
  const char* CMDPREFIX = "_";
  const char* prgname = NULL((void*)0);

  char* cmdname = NULL((void*)0);
  char* sep = NULL((void*)0);
266#ifndef AIX
  Dl_info dl_info;
268#endif

  /* get the executable file name from argv0 */
  prgname = argv0;

273#ifndef AIX
  /*
   * if argv0 doesn't contain an absolute path name, try to get the absolute
   * path name from dladdr; note that this only works for Solaris, not for
   * Linux
   */
  if ( argv0 != NULL((void*)0) && *argv0 != SEPARATOR &&
       dladdr( (void*) &createCommandName, &dl_info ) &&
       dl_info.dli_fname != NULL((void*)0) && *dl_info.dli_fname == SEPARATOR )
  {
      prgname = dl_info.dli_fname;
  }
285#endif

  /* prefix the executable file name by '_' */
  if ( prgname != NULL((void*)0) )
  {
      cmdname = (char*) malloc( strlen( prgname ) + strlen( CMDPREFIX ) + 1 );
      sep = strrchr( prgname, SEPARATOR );
      if ( sep != NULL((void*)0) )
      {
          int pos = ++sep - prgname;
          strncpy( cmdname, prgname, pos );
          cmdname[ pos ] = '\0';
          strcat( cmdname, CMDPREFIX );
          strcat( cmdname, sep );
      }
      else
      {
          strcpy( cmdname, CMDPREFIX );
          strcat( cmdname, prgname );
      }
  }

  return cmdname;
308}

310/* vim:set shiftwidth=4 softtabstop=4 expandtab: */